From: Alex Williamson Date: Tue, 28 Aug 2007 18:30:31 +0000 (-0600) Subject: [IA64] Fixes for 4k page support. X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~14999 X-Git-Url: https://dgit.raspbian.org/%22http:/www.example.com/cgi/%22https:/%22bookmarks://%22Dat/%22http:/www.example.com/cgi/%22https:/%22bookmarks:/%22Dat?a=commitdiff_plain;h=d29ca8d252f1e6d3c11c8ac7f7b07ea2dcf20ac6;p=xen.git [IA64] Fixes for 4k page support. Some code is dependent on PAGE_SIZE and shouldn't be changed. Signed-off-by: Isaku Yamahata --- diff --git a/xen/arch/ia64/xen/faults.c b/xen/arch/ia64/xen/faults.c index aa6b29d0f0..296f50326e 100644 --- a/xen/arch/ia64/xen/faults.c +++ b/xen/arch/ia64/xen/faults.c @@ -729,6 +729,17 @@ ia64_shadow_fault(unsigned long ifa, unsigned long itir, unsigned long pte = 0; struct vhpt_lf_entry *vlfe; + /* + * v->arch.vhpt_pg_shift shouldn't be used here. + * Currently dirty page logging bitmap is allocated based + * on PAGE_SIZE. This is part of xen_domctl_shadow_op ABI. + * If we want to log dirty pages in finer grained when + * v->arch.vhpt_pg_shift < PAGE_SHIFT, we have to + * revise the ABI and update this function and the related + * tool stack (live relocation). + */ + unsigned long vhpt_pg_shift = PAGE_SHIFT; + /* There are 2 jobs to do: - marking the page as dirty (the metaphysical address must be extracted to do that). @@ -744,7 +755,7 @@ ia64_shadow_fault(unsigned long ifa, unsigned long itir, if (vlfe->ti_tag == ia64_ttag(ifa)) { /* The VHPT entry is valid. */ gpfn = get_gpfn_from_mfn((pte & _PAGE_PPN_MASK) >> - v->arch.vhpt_pg_shift); + vhpt_pg_shift); BUG_ON(gpfn == INVALID_M2P_ENTRY); } else { unsigned long itir, iha; @@ -760,10 +771,10 @@ ia64_shadow_fault(unsigned long ifa, unsigned long itir, /* Try again! */ if (fault != IA64_NO_FAULT) { /* This will trigger a dtlb miss. */ - ia64_ptcl(ifa, v->arch.vhpt_pg_shift << 2); + ia64_ptcl(ifa, vhpt_pg_shift << 2); return; } - gpfn = ((pte & _PAGE_PPN_MASK) >> v->arch.vhpt_pg_shift); + gpfn = ((pte & _PAGE_PPN_MASK) >> vhpt_pg_shift); if (pte & _PAGE_D) pte |= _PAGE_VIRT_D; } @@ -791,7 +802,7 @@ ia64_shadow_fault(unsigned long ifa, unsigned long itir, /* Purge the TC locally. It will be reloaded from the VHPT iff the VHPT entry is still valid. */ - ia64_ptcl(ifa, v->arch.vhpt_pg_shift << 2); + ia64_ptcl(ifa, vhpt_pg_shift << 2); atomic64_inc(&d->arch.shadow_fault_count); } else { @@ -803,6 +814,6 @@ ia64_shadow_fault(unsigned long ifa, unsigned long itir, /* We don't know wether or not the fault must be reflected. The VHPT entry is not valid. */ /* FIXME: in metaphysical mode, we could do an ITC now. */ - ia64_ptcl(ifa, v->arch.vhpt_pg_shift << 2); + ia64_ptcl(ifa, vhpt_pg_shift << 2); } } diff --git a/xen/arch/ia64/xen/vhpt.c b/xen/arch/ia64/xen/vhpt.c index 5812c73ba0..16d188c2f4 100644 --- a/xen/arch/ia64/xen/vhpt.c +++ b/xen/arch/ia64/xen/vhpt.c @@ -384,7 +384,12 @@ __domain_flush_vtlb_track_entry(struct domain* d, int cpu; int vcpu; int local_purge = 1; - unsigned char ps = current->arch.vhpt_pg_shift; + + /* tlb inert tracking is done in PAGE_SIZE uint. */ + unsigned char ps = max_t(unsigned char, + current->arch.vhpt_pg_shift, PAGE_SHIFT); + /* This case isn't supported (yet). */ + BUG_ON(current->arch.vhpt_pg_shift > PAGE_SHIFT); BUG_ON((vaddr >> VRN_SHIFT) != VRN7); /*